New feature window pos #2941
Merged
New feature window pos #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Unable to perform a code review. You have run out of credits 😔 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces reusable helper functions restore_window_position() and save_window_position() to standardize window position persistence across pyRevit tools. The pattern is demonstrated by refactoring the "Measure 3D" tool to use these new utilities instead of inline position management code.
Key changes:
- Added
restore_window_position()andsave_window_position()helper functions inpyrevit/script.py - Refactored Measure 3D tool to use new helper functions, removing ~20 lines of duplicated code
- Removed unused
Systemimport from Measure tool
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
pyrevitlib/pyrevit/script.py |
Added two new helper functions for window position persistence with screen visibility validation |
extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Measure.pushbutton/script.py |
Refactored to use new helper functions, removing inline window position management code and unused import |
- store width+height - reuse coreutils function
jmcouffin
added
the
Enhancement
Contributor
|
Great stuff Would you mind opening an issue about all the tools that could benefit from this @Wurschdhaud ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new helper functions
restore_window_position()andsave_window_position()to simplify persistent window positioning across pyRevit sessions. These functions encapsulate the common pattern of storing/restoring window coordinates with screen visibility validation.Implemented in "measure 3d" for testing.
Question for reviewers: Are there better or more Windows-native solutions for handling window position persistence that I should be aware of? I'm not familiar with alternatives beyond this approach.
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Additional Notes
script.load_data()/script.store_data()infrastructureThank you for contributing to pyRevit! 🎉